Skip to content

Fix issue #648 introduced in 0.3.1 #651

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
zhicwu merged 2 commits into from
May 6, 2021
Merged

Fix issue #648 introduced in 0.3.1 #651

zhicwu merged 2 commits into from
May 6, 2021

Conversation

@zhicwu
Copy link
Contributor

@zhicwu zhicwu commented May 6, 2021

  • only ignore database parameter when given DDL contains DATABASE keyword
  • change current database of Statement/PreparedStatement as needed
  • add unit test to address regression issue

@zhicwu zhicwu linked an issue May 6, 2021 that may be closed by this pull request
After update to 0.3.1 datasource ignores database from url #648
Closed
@github-actions
Copy link

github-actions bot commented May 6, 2021 

Benchmark                           (client)  (statement)   Mode  Cnt     Score     Error  Units
Basic.insertOneRandomNumber  clickhouse-jdbc       normal  thrpt   20   283.777 ±  27.155  ops/s
Basic.insertOneRandomNumber  clickhouse-jdbc     prepared  thrpt   20   293.396 ±  30.924  ops/s
Basic.selectOneRandomNumber  clickhouse-jdbc       normal  thrpt   20  2069.373 ± 255.665  ops/s
Basic.selectOneRandomNumber  clickhouse-jdbc     prepared  thrpt   20  1817.879 ± 301.817  ops/s

@zhicwu zhicwu merged commit ef925a4 into ClickHouse:develop May 6, 2021
@zhicwu zhicwu deleted the current-database branch May 6, 2021 02:43
@martenlindblad
Copy link

martenlindblad commented Jun 4, 2021

Thanks for fixing this issue. I think this should be a hotfix since it breaks our current setup. We can't use 0.3.1 and it seems like 0.3.2 still is far away from release.

@zhicwu zhicwu mentioned this pull request Jun 7, 2021
Closed
@zhicwu
Copy link
Contributor Author

zhicwu commented Jun 7, 2021

Thanks for fixing this issue. I think this should be a hotfix since it breaks our current setup. We can't use 0.3.1 and it seems like 0.3.2 still is far away from release.

Sorry I've been lazy lately :p Just released 0.3.1-patch for this and I'll expedite 0.3.2 release(for real ;).

@zhicwu zhicwu linked an issue Jun 15, 2021 that may be closed by this pull request
Why DDL statements ignore database setting? #674
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Why DDL statements ignore database setting? After update to 0.3.1 datasource ignores database from url

2 participants

@zhicwu @martenlindblad